Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 800063003: Ozone: Temporarily remove DCHECK in BufferFactory. (Closed)

Created:
6 years ago by kalyank
Modified:
6 years ago
Reviewers:
dnicoara, achaulk, spang
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank, alexst (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone: Temporarily remove DCHECK in BufferFactory. https://codereview.chromium.org/795053006/ added support for EGLClientBuffer to work around dma_buf issues and also we have support to export the buffer to dma_buf handle. This conflicts with the DCHECK in bufferfactory. BUG=434115 Committed: https://crrev.com/2473eeec5460bcc4c2bb8b9caf01cc656154b6f0 Cr-Commit-Position: refs/heads/master@{#308163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
kalyank
6 years ago (2014-12-12 19:05:32 UTC) #2
dnicoara
+spang@ since he's the owner. lgtm ... perhaps it should be commented out with a ...
6 years ago (2014-12-12 19:16:48 UTC) #4
spang
lgtm
6 years ago (2014-12-12 19:24:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800063003/1
6 years ago (2014-12-12 19:25:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 21:28:34 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-12 21:29:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2473eeec5460bcc4c2bb8b9caf01cc656154b6f0
Cr-Commit-Position: refs/heads/master@{#308163}

Powered by Google App Engine
This is Rietveld 408576698