app_list: OnExtensionLoaded calls UpdateResults asynchronously rather than directly.

chrome/browser/ui/app_list/search/app_search_provider.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/search/app_search_provider.h"
 
 #include <string>
 
+#include "base/bind.h"
+#include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/clock.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_ui_util.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/search/app_result.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
@@ skipping 26 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(App);
 };
 
 AppSearchProvider::AppSearchProvider(Profile* profile,
                                      AppListControllerDelegate* list_controller,
                                      scoped_ptr<base::Clock> clock)
     : profile_(profile),
       list_controller_(list_controller),
       extension_registry_observer_(this),
-      clock_(clock.Pass()) {
+      clock_(clock.Pass()),
+      update_results_factory_(this) {
   extension_registry_observer_.Add(ExtensionRegistry::Get(profile_));
   RefreshApps();
 }
 
 AppSearchProvider::~AppSearchProvider() {}
 
 void AppSearchProvider::Start(bool /*is_voice_query*/,
                               const base::string16& query) {
   query_ = query;
   const TokenizedString query_terms(query);
@@ skipping 28 matching lines @@
                                      (*app_it)->last_launch_time());
     } else {
       TokenizedStringMatch match;
       if (!match.Calculate(query_terms, (*app_it)->indexed_name()))
         continue;
 
       result->UpdateFromMatch((*app_it)->indexed_name(), match);
     }
     Add(result.Pass());
   }
+
+  update_results_factory_.InvalidateWeakPtrs();

[tapted, 2015/01/07 04:12:30]

TBH I haven't used WeakPtrs in Chrome all that much. But I think this step is
here to handle an UpdateResults call that doesn't come asynchronously via the
closure (otherwise it would only invalidate the weak pointer in the closure,
which is about to be cleaned up anyway).

However, in that case, it would be possible for things to be ordered like

OnExtensionLoaded [queue UpdateResults]
explicit UpdateResults (via Start()?) [invalidate queue]
OnExtensionLoaded [skip queuing UpdateResult since HasWeakPtrs]
async UpdateResults also skipped because it got invalidated
* still missing UpdateResults to handle the second OnExtensionLoaded


I *think* this line can just be removed to fix that case. The downside could be
that we do two UpdateResults() in a row without a refresh, but that's fine.

[xiyuan, 2015/01/07 04:51:57]

WeakPtrFactory::InvalidateWeakPtrs would mark the WeakPtr flag invalid and
release its reference to the flag. This way, all previous WeakPtrs returned from
its GetWeakPtr() call become invalid and unusable. And HasWeakPtrs would return
false because the flag is gone and the factory does not hold any WeakPtr.

So the case you worry about actually works. The explicit UpdateResults call
invalidates previous WeakPtr and effectively cancels the previous queued
UpdateResults call. The next OnExtensionLoaded would queue a new call because
HasWeakPtrs returns false now.

 }
 
 void AppSearchProvider::AddApps(const extensions::ExtensionSet& extensions) {
   extensions::ExtensionPrefs* prefs = extensions::ExtensionPrefs::Get(profile_);
   for (extensions::ExtensionSet::const_iterator iter = extensions.begin();
        iter != extensions.end(); ++iter) {
     const extensions::Extension* app = iter->get();
 
     if (!extensions::ui_util::ShouldDisplayInAppLauncher(app, profile_))
       continue;
@@ skipping 11 matching lines @@
   ExtensionRegistry* registry = ExtensionRegistry::Get(profile_);
   AddApps(registry->enabled_extensions());
   AddApps(registry->disabled_extensions());
   AddApps(registry->terminated_extensions());
 }
 
 void AppSearchProvider::OnExtensionLoaded(
     content::BrowserContext* browser_context,
     const extensions::Extension* extension) {
   RefreshApps();
-  UpdateResults();
+  if (!update_results_factory_.HasWeakPtrs()) {
+    base::MessageLoop::current()->PostTask(
+        FROM_HERE,
+        base::Bind(&AppSearchProvider::UpdateResults,
+                   update_results_factory_.GetWeakPtr()));
+  }
 }
 
 void AppSearchProvider::OnExtensionUninstalled(
     content::BrowserContext* browser_context,
     const extensions::Extension* extension,
     extensions::UninstallReason reason) {
   RefreshApps();
-  UpdateResults();
+  if (!update_results_factory_.HasWeakPtrs()) {
+    base::MessageLoop::current()->PostTask(
+        FROM_HERE,
+        base::Bind(&AppSearchProvider::UpdateResults,
+                   update_results_factory_.GetWeakPtr()));
+  }
 }
 
 }  // namespace app_list