Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 800013002: Removed references to linux_gpu, which has been removed (Closed)

Created:
6 years ago by Sergiy Byelozyorov
Modified:
5 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_mac_gpu_bots_from_presubmit
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed references to linux_gpu, which has been removed BUG=426897 R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org Committed: https://crrev.com/10ab0cd5283918b42e43443fa0cf952d572a5103 Cr-Commit-Position: refs/heads/master@{#313978}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M PRESUBMIT.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M PRESUBMIT_test.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (7 generated)
Sergiy Byelozyorov
6 years ago (2014-12-12 16:53:49 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years ago (2014-12-12 17:45:22 UTC) #2
Zhenyao Mo
LGTM
6 years ago (2014-12-12 17:49:40 UTC) #3
Ken Russell (switch to Gerrit)
LGTM once the question above is answered. https://codereview.chromium.org/800013002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/800013002/diff/1/PRESUBMIT.py#newcode1698 PRESUBMIT.py:1698: 'linux_chromium_rel_ng': ['defaulttests'], ...
6 years ago (2014-12-12 18:45:40 UTC) #4
Sergiy Byelozyorov
https://codereview.chromium.org/800013002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/800013002/diff/1/PRESUBMIT.py#newcode1698 PRESUBMIT.py:1698: 'linux_chromium_rel_ng': ['defaulttests'], On 2014/12/12 18:45:40, Ken Russell wrote: > ...
6 years ago (2014-12-22 14:55:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800013002/1
5 years, 10 months ago (2015-01-28 18:32:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/53194) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/5142) ios_rel_device_ninja_ng ...
5 years, 10 months ago (2015-01-28 18:36:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800013002/20001
5 years, 10 months ago (2015-01-28 19:08:07 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38959)
5 years, 10 months ago (2015-01-28 19:13:37 UTC) #13
Sergiy Byelozyorov
piman@chromium.org: Please review changes in
5 years, 10 months ago (2015-01-28 19:17:30 UTC) #15
piman
lgtm
5 years, 10 months ago (2015-01-30 20:18:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800013002/20001
5 years, 10 months ago (2015-01-30 20:20:09 UTC) #18
commit-bot: I haz the power
This issue passed the CQ. To commit it, remove "COMMIT=false" from the description and try ...
5 years, 10 months ago (2015-01-30 20:24:28 UTC) #19
Ken Russell (switch to Gerrit)
These bots are gone at this point. I'm removing the COMMIT=false from the CL description.
5 years, 10 months ago (2015-01-30 20:30:50 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800013002/20001
5 years, 10 months ago (2015-01-30 20:32:09 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 20:33:34 UTC) #23
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 20:34:46 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10ab0cd5283918b42e43443fa0cf952d572a5103
Cr-Commit-Position: refs/heads/master@{#313978}

Powered by Google App Engine
This is Rietveld 408576698