Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 799943003: Fix OS::GetCurrentThreadId to work when building Android on Mac. (Closed)

Created:
6 years ago by rmcilroy
Modified:
6 years ago
CC:
v8-dev, benm (inactive)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix OS::GetCurrentThreadId to work when building Android on Mac. The Mac version of GetCurrentThreadId should be used when building the host build of V8 on Android for Mac.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/base/platform/platform-posix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rmcilroy
Jochen: could you please take a look at this CL.
6 years ago (2014-12-12 16:31:49 UTC) #2
jochen (gone - plz use gerrit)
lgtm.
6 years ago (2014-12-12 16:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799943003/1
6 years ago (2014-12-12 16:43:51 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-12 17:56:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698