Source/core/frame/History.cpp - Issue 799923006: Make canNavigate() OOPI-friendly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/History.cpp

Issue 799923006: Make canNavigate() OOPI-friendly (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/History.cpp

diff --git a/Source/core/frame/History.cpp b/Source/core/frame/History.cpp

index d0f861ab9613c7a9ab369057c25e5c0100f48918..a98b566f7a7e2e2f73d8e9627307c3f93b0eed9a 100644

--- a/Source/core/frame/History.cpp

+++ b/Source/core/frame/History.cpp

@@ -106,7 +106,7 @@ void History::go(ExecutionContext* context, int distance)

if (!activeDocument)

return;

- if (!activeDocument->canNavigate(*m_frame))

+ if (!activeDocument->frame()->canNavigate(*m_frame))

dcheng 2015/01/08 23:17:26 Does this need a similar null check for frame()/

Nate Chapin 2015/01/09 00:12:46 Done.

return;

if (distance)

« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »