Make canNavigate() OOPI-friendly

Source/core/frame/LocalDOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 994 matching lines @@
     Page* page = frame()->page();
     if (!page)
         return;
 
     if (context) {
         ASSERT(isMainThread());
         Document* activeDocument = toDocument(context);
         if (!activeDocument)
             return;
 
-        if (!activeDocument->canNavigate(*frame()))
+        if (!activeDocument->frame()->canNavigate(*frame()))
             return;
     }
 
     Settings* settings = frame()->settings();
     bool allowScriptsToCloseWindows = settings && settings->allowScriptsToCloseWindows();
 
     if (!page->openedByDOM() && frame()->loader().client()->backForwardLength() > 1 && !allowScriptsToCloseWindows) {
         frameConsole()->addMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Scripts may close only the windows that were opened by it."));
         return;
     }
@@ skipping 675 matching lines @@
 void LocalDOMWindow::setLocation(const String& urlString, LocalDOMWindow* callingWindow, LocalDOMWindow* enteredWindow, SetLocationLocking locking)
 {
     if (!isCurrentlyDisplayedInFrame())
         return;
 
     Document* activeDocument = callingWindow->document();
     if (!activeDocument)
         return;
 
     ASSERT(frame());
-    if (!activeDocument->canNavigate(*frame()))
+    if (!activeDocument->frame() || !activeDocument->frame()->canNavigate(*frame()))

[dcheng, 2015/01/08 00:44:59]

Why does this one require a null check of frame(), while several other instances
do not?

[Nate Chapin, 2015/01/08 17:10:52]

Um.....because this is the only one required to make the layout tests pass? :D

Will add the null checks in the other locations, they're almost certainly
crashable.

[dcheng, 2015/01/08 23:20:19]

Any chance you have a crash stack handy? I'm curious how this was getting
triggered.

         return;
 
     LocalFrame* firstFrame = enteredWindow->frame();
     if (!firstFrame)
         return;
 
     KURL completedURL = firstFrame->document()->completeURL(urlString);
     if (completedURL.isNull())
         return;
 
@@ skipping 147 matching lines @@
         targetFrame = frame()->tree().top();
     else if (frameName == "_parent") {
         if (Frame* parent = frame()->tree().parent())
             targetFrame = parent;
         else
             targetFrame = frame();
     }
     // FIXME: Navigating RemoteFrames is not yet supported.
     if (targetFrame && targetFrame->isLocalFrame()) {
         LocalFrame* localTargetFrame = toLocalFrame(targetFrame);
-        if (!activeDocument->canNavigate(*localTargetFrame))
+        if (!activeDocument->frame()->canNavigate(*localTargetFrame))
             return nullptr;
 
         KURL completedURL = firstFrame->document()->completeURL(urlString);
 
         if (localTargetFrame->localDOMWindow()->isInsecureScriptAccess(*callingWindow, completedURL))
             return localTargetFrame->localDOMWindow();
 
         if (urlString.isEmpty())
             return localTargetFrame->localDOMWindow();
 
@@ skipping 78 matching lines @@
     return m_frameObserver->frame();
 }
 
 v8::Handle<v8::Object> LocalDOMWindow::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     ASSERT_NOT_REACHED(); // LocalDOMWindow has [Custom=ToV8].
     return v8::Handle<v8::Object>();
 }
 
 } // namespace blink