Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 799923003: Changes to third_party/cython build rules to allow source sets for (Closed)

Created:
6 years ago by etiennej
Modified:
5 years, 11 months ago
Reviewers:
jamesr, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes to third_party/cython build rules to allow source sets for python modules composed of C++ and/or Cython files. This change is necessary for https://codereview.chromium.org/792843002/. It is also backward-incompatible with the current mojo/public/python build rules; I change them in the same changelist to avoid the dependency issue. Once this CL lands, I will roll the changes into the mojo repository from chromium. R=qsr@chromium.org,jamesr@chromium.org Committed: https://crrev.com/560d48f40a669bfaf06a830d0cefb926628b0ed1 Cr-Commit-Position: refs/heads/master@{#308331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -52 lines) Patch
M mojo/public/python/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/cython/rules.gni View 3 chunks +68 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
etiennej
6 years ago (2014-12-12 16:01:21 UTC) #1
qsr
lgtm
6 years ago (2014-12-12 16:50:02 UTC) #2
jamesr
mojo/ lgtm I don't really know anything about cython
6 years ago (2014-12-13 01:47:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799923003/1
6 years ago (2014-12-15 08:59:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 09:50:47 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 09:51:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/560d48f40a669bfaf06a830d0cefb926628b0ed1
Cr-Commit-Position: refs/heads/master@{#308331}

Powered by Google App Engine
This is Rietveld 408576698