Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/cygprofile/symbolize.py

Issue 799893003: Fix pylint error in patch_orderfile and symbolize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use super instead of Exception Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/cygprofile/patch_orderfile.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cygprofile/symbolize.py
diff --git a/tools/cygprofile/symbolize.py b/tools/cygprofile/symbolize.py
index 027da57a521ac95975d598e60687ae50877c2aba..09896c6f0f650c2d08364fd66dd0c1057a39cc4a 100755
--- a/tools/cygprofile/symbolize.py
+++ b/tools/cygprofile/symbolize.py
@@ -39,7 +39,6 @@ def ParseLogLines(log_file_lines):
function address called)
"""
call_lines = []
- has_started = False
vm_start = 0
line = log_file_lines[0]
assert("r-xp" in line)
@@ -113,6 +112,7 @@ def ParseLibSymbols(lib_file):
class SymbolNotFoundException(Exception):
def __init__(self,value):
+ super(SymbolNotFoundException,self).__init__(value)
self.value = value
def __str__(self):
return repr(self.value)
@@ -201,7 +201,6 @@ def main():
(log_file, lib_file) = args
output_type = options.output_type
- lib_name = lib_file.split('/')[-1].strip()
log_file_lines = map(string.rstrip, open(log_file).readlines())
call_info = ParseLogLines(log_file_lines)
(unique_addrs, address_map) = ParseLibSymbols(lib_file)
@@ -229,7 +228,7 @@ def main():
for symbol in symbols:
print '.text.' + symbol
print ''
- except SymbolNotFoundException as e:
+ except SymbolNotFoundException:
sys.stderr.write('WARNING: Did not find function in binary. addr: '
+ hex(addr) + '\n')
else:
@@ -243,7 +242,7 @@ def main():
print '\t\t\t\t\t' + symbol
else:
first_symbol = False
- except SymbolNotFoundException as e:
+ except SymbolNotFoundException:
sys.stderr.write('WARNING: Did not find function in binary. addr: '
+ hex(addr) + '\n')
« no previous file with comments | « tools/cygprofile/patch_orderfile.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698