src/execution.h - Issue 799853003: Use proper ToLength() operation in %ArrayConcat()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/execution.h

Issue 799853003: Use proper ToLength() operation in %ArrayConcat() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Try ToUint32 before calling JS ToLength() Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/execution.h

diff --git a/src/execution.h b/src/execution.h

index 89175cd906d80a9533a47013ba2f0ec129b67fdf..ae263bddd7c42bd12e486b7890f2e741bc0a24f3 100644

--- a/src/execution.h

+++ b/src/execution.h

@@ -69,6 +69,11 @@ class Execution FINAL : public AllStatic {

MUST_USE_RESULT static MaybeHandle<Object> ToUint32(

Isolate* isolate, Handle<Object> obj);

+ // ES6, draft 10-14-14, section 7.1.15

+ MUST_USE_RESULT static MaybeHandle<Object> ToLength(

+ Isolate* isolate, Handle<Object> obj);

// ECMA-262 9.8

MUST_USE_RESULT static MaybeHandle<Object> ToString(

Isolate* isolate, Handle<Object> obj);