Source/core/html/parser/HTMLDocumentParser.h - Issue 799803004: Demistify DocumentParser::append

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/HTMLDocumentParser.h

Issue 799803004: Demistify DocumentParser::append (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: resurrect fixme Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/parser/HTMLDocumentParser.h

diff --git a/Source/core/html/parser/HTMLDocumentParser.h b/Source/core/html/parser/HTMLDocumentParser.h

index 0cd4e4d40bb794005a07f545a3e6bf598daba3a6..35e652b8c1a841034a04f9da77f77d21bbf5d563 100644

--- a/Source/core/html/parser/HTMLDocumentParser.h

+++ b/Source/core/html/parser/HTMLDocumentParser.h

@@ -111,7 +111,7 @@ public:

protected:

virtual void insert(const SegmentedString&) override final;

- virtual void append(PassRefPtr<StringImpl>) override;

+ virtual void append(const String&) override;

virtual void finish() override final;

HTMLDocumentParser(HTMLDocument&, bool reportErrors, ParserSynchronizationPolicy);