Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: Source/core/dom/DocumentParser.h

Issue 799803004: Demistify DocumentParser::append (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: resurrect fixme Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/RawDataDocumentParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DocumentParser.h
diff --git a/Source/core/dom/DocumentParser.h b/Source/core/dom/DocumentParser.h
index 2863cb73eb4b33c234f49164834758cd82d74c79..2bd668c60715a5e9ab299e9e05ba9eb92b8d65ed 100644
--- a/Source/core/dom/DocumentParser.h
+++ b/Source/core/dom/DocumentParser.h
@@ -56,10 +56,8 @@ public:
virtual TextResourceDecoder* decoder();
virtual void setHasAppendedData() { }
- // FIXME: append() should be private, but DocumentLoader::replaceDocumentWhileExecutingJavaScriptURL uses it for now.
- // FIXME: This really should take a PassOwnPtr to signify that it expects to take
- // ownership of the buffer. The parser expects the PassRefPtr to hold the only ref of the StringImpl.
- virtual void append(PassRefPtr<StringImpl>) = 0;
+ // FIXME: append() should be private, but DocumentLoader and DOMPatchSupport uses it for now.
+ virtual void append(const String&) = 0;
virtual void finish() = 0;
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/RawDataDocumentParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698