Source/core/xml/parser/XMLDocumentParser.cpp - Issue 799803004: Demistify DocumentParser::append

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/parser/XMLDocumentParser.cpp

Issue 799803004: Demistify DocumentParser::append (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/parser/XMLDocumentParser.cpp

diff --git a/Source/core/xml/parser/XMLDocumentParser.cpp b/Source/core/xml/parser/XMLDocumentParser.cpp

index 531e397b7eddf871ba1add52cc4876c270b0355e..d528f88fc544985d80eb386282534417ed8b8b93 100644

--- a/Source/core/xml/parser/XMLDocumentParser.cpp

+++ b/Source/core/xml/parser/XMLDocumentParser.cpp

@@ -347,7 +347,7 @@ void XMLDocumentParser::insert(const SegmentedString&)

ASSERT_NOT_REACHED();

}

-void XMLDocumentParser::append(PassRefPtr<StringImpl> inputSource)

+void XMLDocumentParser::append(const String& inputSource)

{

SegmentedString source(inputSource);

if (m_sawXSLTransform || !m_sawFirstElement)