Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 799753009: Added GPU Tracing for DoSwapBuffers() to track frames. (Closed)

Created:
5 years, 11 months ago by David Yen
Modified:
5 years, 11 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added GPU Tracing for DoSwapBuffers() to track frames. R=vmiura@chromium.org BUG=None TEST=tracing locally and trybots Committed: https://crrev.com/b547eff63cbe7915254a1a4e9596cfe6cac94a91 Cr-Commit-Position: refs/heads/master@{#311985}

Patch Set 1 #

Patch Set 2 : Removed unnecessary include #

Patch Set 3 : Move synchronous trace modification to its own CL #

Total comments: 4

Patch Set 4 : Use generic scoped gpu tracer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.h View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
David Yen
5 years, 11 months ago (2015-01-16 18:49:51 UTC) #1
David Yen
disregard, I can just use the gpu_decoder "kSwapBuffers" one.
5 years, 11 months ago (2015-01-16 19:32:03 UTC) #2
David Yen
On 2015/01/16 19:32:03, David Yen wrote: > disregard, I can just use the gpu_decoder "kSwapBuffers" ...
5 years, 11 months ago (2015-01-16 19:37:10 UTC) #3
vmiura
https://codereview.chromium.org/799753009/diff/40001/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/799753009/diff/40001/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode9758 gpu/command_buffer/service/gles2_cmd_decoder.cc:9758: GPUSwapBufferTrace(GPUTracer* gpu_tracer, int frame) As discussed offline, maybe make ...
5 years, 11 months ago (2015-01-16 20:39:34 UTC) #4
David Yen
https://codereview.chromium.org/799753009/diff/40001/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/799753009/diff/40001/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode9758 gpu/command_buffer/service/gles2_cmd_decoder.cc:9758: GPUSwapBufferTrace(GPUTracer* gpu_tracer, int frame) On 2015/01/16 20:39:34, vmiura wrote: ...
5 years, 11 months ago (2015-01-16 21:34:20 UTC) #5
vmiura
LGTM
5 years, 11 months ago (2015-01-16 22:50:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799753009/60001
5 years, 11 months ago (2015-01-16 22:59:23 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-17 00:15:26 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-17 00:16:18 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b547eff63cbe7915254a1a4e9596cfe6cac94a91
Cr-Commit-Position: refs/heads/master@{#311985}

Powered by Google App Engine
This is Rietveld 408576698