Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 799683003: Move chromeos::version_loader to src/chromeos/system (Closed)

Created:
6 years ago by satorux1
Modified:
6 years ago
Reviewers:
xiyuan, oshima
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move chromeos::version_loader to src/chromeos/system In favor of less things to have in chrome/browser/chromeos. BUG=437719 TEST=everything builds as before Committed: https://crrev.com/66d48f350f12c2ecf65b2a002dcc930e85f8deba Cr-Commit-Position: refs/heads/master@{#308209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -174 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/version_loader.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/chromeos/version_loader.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/chromeos/version_loader_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_handler_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A + chromeos/system/version_loader.h View 2 chunks +8 lines, -6 lines 0 comments Download
A + chromeos/system/version_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/system/version_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
satorux1
oshima: c/b/chromeos and chromeos xiyuan: chrome/browser/ui/webui
6 years ago (2014-12-12 03:42:47 UTC) #2
xiyuan
lgtm
6 years ago (2014-12-12 04:37:54 UTC) #3
oshima
lgtm
6 years ago (2014-12-12 22:47:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799683003/1
6 years ago (2014-12-12 23:00:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 01:01:29 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-13 01:02:21 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/66d48f350f12c2ecf65b2a002dcc930e85f8deba
Cr-Commit-Position: refs/heads/master@{#308209}

Powered by Google App Engine
This is Rietveld 408576698