Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: DEPS

Issue 799673003: Always download google_play_services zip package instead of rsync. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment length to be > 80 chars. Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/download_sdk_extras.py » ('j') | build/download_sdk_extras.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: DEPS
diff --git a/DEPS b/DEPS
index 379f7ef7225b6f55bee00333ec422d03d6276b0f..f3b934f971d1609058d7b6b451d4c1105ba38f4b 100644
--- a/DEPS
+++ b/DEPS
@@ -558,9 +558,9 @@ hooks = [
# need to manually install these packages and accept the ToS.
'name': 'sdkextras',
'pattern': '.',
- # Make sure to add package to .gitignore in third_party/android_tools.
+ # Add package and zip file to .gitignore in third_party/android_tools.
cjhopman 2014/12/31 00:39:28 What does this comment mean? Does this action add
navabi 2015/01/06 00:32:09 The comment is instructing the person that adds ar
cjhopman 2015/01/06 02:04:04 Oh, that makes sense. Could you maybe add: "When c
'action': ['python', 'src/build/download_sdk_extras.py',
- 'google_google_play_services_21.0.0'],
+ 'google_google_play_services_21.0.0.zip'],
},
{
# Downloads the Debian Wheezy sysroot to chrome/installer/linux if needed.
« no previous file with comments | « no previous file | build/download_sdk_extras.py » ('j') | build/download_sdk_extras.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698