DEPS - Issue 799673003: Always download google_play_services zip package instead of rsync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: DEPS

Issue 799673003: Always download google_play_services zip package instead of rsync. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't manually check returncode. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: DEPS

diff --git a/DEPS b/DEPS

index e94ff353cd949df15f0961117b59ecac5dbc8e8f..60f58afaf49da5a811b0a503e7081742306d45ca 100644

--- a/DEPS

+++ b/DEPS

@@ -558,9 +558,10 @@ hooks = [

# need to manually install these packages and accept the ToS.

'name': 'sdkextras',

'pattern': '.',

- # Make sure to add package to .gitignore in third_party/android_tools.

+ # When adding a new sdk extras package to download, add the package

+ # directory and zip file to .gitignore in third_party/android_tools.

'action': ['python', 'src/build/download_sdk_extras.py',

- 'google_google_play_services_21.0.0'],

+ 'google_google_play_services_21.0.0.zip'],

{

# Downloads the Debian Wheezy sysroot to chrome/installer/linux if needed.

« no previous file with comments | « no previous file | build/download_sdk_extras.py » ('j') | build/download_sdk_extras.py » ('J')