Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: pdf/BUILD.gn

Issue 799643004: Combine PDF plugin into the Chromium binary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pdf/BUILD.gn
diff --git a/pdf/BUILD.gn b/pdf/BUILD.gn
index b028290ba2dcb805a087982c1ce7d946ca8358a6..4ecd961fb9586e683b7284848af8d17f67411999 100644
--- a/pdf/BUILD.gn
+++ b/pdf/BUILD.gn
@@ -4,8 +4,7 @@
pdf_engine = 0 # 0 PDFium
-# TODO(GYP) need support for loadable modules
-shared_library("pdf") {
+static_library("pdf") {
sources = [
"button.h",
"button.cc",
@@ -35,7 +34,6 @@ shared_library("pdf") {
"paint_manager.h",
"pdf.cc",
"pdf.h",
- "pdf.rc",
"progress_control.cc",
"progress_control.h",
"pdf_engine.h",
@@ -45,8 +43,6 @@ shared_library("pdf") {
"resource_consts.h",
"thumbnail_control.cc",
"thumbnail_control.h",
- "../components/ui/zoom/page_zoom_constants.cc",
- "../content/common/page_zoom.cc",
]
if (pdf_engine == 0) {
@@ -68,33 +64,15 @@ shared_library("pdf") {
}
if (is_win) {
- defines = [ "COMPILE_CONTENT_STATICALLY" ]
cflags = [ "/wd4267" ] # TODO(jschuh) size_t to int truncations.
}
- if (is_mac) {
- # TODO(GYP)
- #'mac_bundle': 1,
- #'product_name': 'PDF',
- #'product_extension': 'plugin',
- ## Strip the shipping binary of symbols so "Foxit" doesn't appear in
- ## the binary. Symbols are stored in a separate .dSYM.
- #'variables': {
- # 'mac_real_dsym': 1,
- #},
- #'sources+': [
- # 'Info.plist'
- #]
- #'xcode_settings': {
- # 'INFOPLIST_FILE': 'Info.plist',
- #},
- }
-
deps = [
"//base",
+ "//components/ui/zoom:ui_zoom",
+ "//content/public/common",
"//net",
- "//ppapi:ppapi_cpp",
+ "//ppapi:ppapi_internal_module",
"//third_party/pdfium",
]
}
-# TODO(GYP) pdf_linux_symbols target.
« no previous file with comments | « chrome/utility/printing_handler.cc ('k') | pdf/Info.plist » ('j') | pdf/pdf.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698