Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: chrome/BUILD.gn

Issue 799643004: Combine PDF plugin into the Chromium binary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | chrome/DEPS » ('j') | chrome/renderer/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index f4414af23fb420bfe2c67a66a2bdd0384348175c..d9d87eebd16a980b1ac423ed71d1e85707bfead6 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -111,10 +111,8 @@ if (!is_android) {
# TODO(GYP) some stuff from GYP including chrome_multiple_dll.
}
- if (!is_mac) {
- # On Mac this is done in chrome_dll.gypi.
- datadeps += [ "//pdf" ]
- # TODO(GYP) pdf linux symbols
+ if (enable_plugins) {
+ deps += [ "//pdf" ]
}
}
} # !is_android
@@ -197,6 +195,10 @@ shared_library("main_dll") {
#}],
# TODO(GYP) Lots of other stuff in the OS=="mac" block.
}
+
+ if (enable_plugins) {
+ deps += [ "//pdf" ]
+ }
}
# GYP version: chromium_browser_dependencies variable in chrome.gyp
« no previous file with comments | « build/all.gyp ('k') | chrome/DEPS » ('j') | chrome/renderer/DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698