Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 799643003: Add an event time parameter to didStartProvisionalLoad callbacks (Closed)

Created:
6 years ago by Nate Chapin
Modified:
6 years ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an event time parameter to didStartProvisionalLoad callbacks This removes the only caller of WebDataSource::triggeringEventTime(), which is transient data we probably shouldn't be stashing on a long-lived class anyway. BUG= Committed: https://crrev.com/69a06300b7a90448bcd803115955765920c240fc Cr-Commit-Position: refs/heads/master@{#308145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nate Chapin
blink-side: http://src.chromium.org/viewvc/blink?view=revision&revision=186990 This will help enable some cleanup in blink's loader. See https://codereview.chromium.org/790383002/ for the ...
6 years ago (2014-12-11 23:37:43 UTC) #2
nasko
LGTM
6 years ago (2014-12-11 23:56:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799643003/1
6 years ago (2014-12-12 18:26:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 19:37:24 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 19:38:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69a06300b7a90448bcd803115955765920c240fc
Cr-Commit-Position: refs/heads/master@{#308145}

Powered by Google App Engine
This is Rietveld 408576698