Make Windows accessibility event firing aware of guest / child frames.

content/browser/frame_host/frame_accessibility.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_accessibility.h"
 
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/render_frame_host_delegate.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
@@ skipping 87 matching lines @@
     int accessibility_node_id) {
   for (std::vector<ChildFrameMapping>::iterator iter = mappings_.begin();
        iter != mappings_.end();
        ++iter) {
     if (iter->parent_frame_host != parent_frame_host ||
         iter->accessibility_node_id != accessibility_node_id) {
       continue;
     }
 
     if (iter->child_frame_tree_node_id) {
-      FrameTreeNode* child_node =
-          FrameTree::GloballyFindByID(iter->child_frame_tree_node_id);
-      if (!child_node)
-        return NULL;
+      return GetRFHIFromFrameTreeNodeId(
+          parent_frame_host, iter->child_frame_tree_node_id);
 
-      // We should have gotten a node in the same frame tree.
-      if (child_node->frame_tree() !=
-              parent_frame_host->frame_tree_node()->frame_tree()) {
-        NOTREACHED();
-        return NULL;
-      }
-
-      return child_node->current_frame_host();
     }
 
     if (iter->browser_plugin_instance_id) {
       RenderFrameHost* guest =
           parent_frame_host->delegate()->GetGuestByInstanceID(
               iter->browser_plugin_instance_id);
       if (guest)
         return static_cast<RenderFrameHostImpl*>(guest);
     }
   }
 
   return NULL;
 }
 
+void FrameAccessibility::GetAllChildFrames(
+    RenderFrameHostImpl* parent_frame_host,
+    std::vector<RenderFrameHostImpl*>* child_frame_hosts) {
+  CHECK(child_frame_hosts);
+
+  for (std::vector<ChildFrameMapping>::iterator iter = mappings_.begin();
+       iter != mappings_.end();
+       ++iter) {
+    if (iter->parent_frame_host != parent_frame_host)
+      continue;
+
+    if (iter->child_frame_tree_node_id) {
+      RenderFrameHostImpl* child_frame_host = GetRFHIFromFrameTreeNodeId(
+          parent_frame_host, iter->child_frame_tree_node_id);
+      if (child_frame_host)
+        child_frame_hosts->push_back(child_frame_host);
+    }
+
+    if (iter->browser_plugin_instance_id) {
+      RenderFrameHost* guest =
+          parent_frame_host->delegate()->GetGuestByInstanceID(
+              iter->browser_plugin_instance_id);
+      if (guest)
+        child_frame_hosts->push_back(static_cast<RenderFrameHostImpl*>(guest));
+    }
+  }
+}
+
 bool FrameAccessibility::GetParent(
     RenderFrameHostImpl* child_frame_host,
     RenderFrameHostImpl** out_parent_frame_host,
     int* out_accessibility_node_id) {
   for (std::vector<ChildFrameMapping>::iterator iter = mappings_.begin();
        iter != mappings_.end();
        ++iter) {
     if (iter->child_frame_tree_node_id) {
       FrameTreeNode* child_node =
           FrameTree::GloballyFindByID(iter->child_frame_tree_node_id);
@@ skipping 24 matching lines @@
         if (out_accessibility_node_id)
           *out_accessibility_node_id = iter->accessibility_node_id;
         return true;
       }
     }
   }
 
   return false;
 }
 
+RenderFrameHostImpl* FrameAccessibility::GetRFHIFromFrameTreeNodeId(
+    RenderFrameHostImpl* parent_frame_host,
+    int64 child_frame_tree_node_id) {
+  FrameTreeNode* child_node =
+      FrameTree::GloballyFindByID(child_frame_tree_node_id);
+  if (!child_node)
+    return NULL;

[nasko, 2015/01/15 21:44:38]

s/NULL/nullptr/

[dmazzoni, 2015/01/15 23:09:22]

Done.

+
+  // We should have gotten a node in the same frame tree.
+  if (child_node->frame_tree() !=
+      parent_frame_host->frame_tree_node()->frame_tree()) {
+    NOTREACHED();
+    return NULL;

[nasko, 2015/01/15 21:44:38]

s/NULL/nullptr/

[dmazzoni, 2015/01/15 23:09:22]

Done.

+  }
+
+  return child_node->current_frame_host();

[nasko, 2015/01/15 21:44:38]

There is no verification that the frame found is a direct child of the passed in
RFH.

[dmazzoni, 2015/01/15 23:09:22]

True. Note that this is not new logic, I just refactored it out of
FrameAccessibility::GetChild, above, since it's also needed by
FrameAccessibility::GetAllChildFrames.

I added a check, does that look right?

[nasko, 2015/01/16 00:20:33]

Yeah, I saw it is just moved, but it is useful to improve as we move, right?
 
I don't see a check here, I see a check in FrameAccessibility::GetParent.

+}
+
 }  // namespace content