Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 799623003: Reimplement EasyUnlock.StartupTimeFromSuspend metric. (Closed)

Created:
6 years ago by Tim Song
Modified:
6 years ago
Reviewers:
xiyuan, Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reimplement EasyUnlock.StartupTimeFromSuspend metric. The metric in the app was broken for a while now. We will fix the metric natively so we don't have to deal with app lifetime issues. BUG=433697 Committed: https://crrev.com/06b9bfc16818e27a982e108053a880aea45a9f54 Cr-Commit-Position: refs/heads/master@{#308180}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : style #

Patch Set 3 : fix compile on mac/win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M chrome/browser/signin/easy_unlock_service.cc View 1 2 5 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Tim Song
6 years ago (2014-12-12 01:48:27 UTC) #3
Tim Song
6 years ago (2014-12-12 01:48:47 UTC) #5
Ilya Sherman
LGTM, thanks. Please remember to also remove the metric from being recorded by the app, ...
6 years ago (2014-12-12 01:54:43 UTC) #6
xiyuan
LGTM with isherman's comments addressed.
6 years ago (2014-12-12 02:01:54 UTC) #7
Tim Song
https://codereview.chromium.org/799623003/diff/20001/chrome/browser/signin/easy_unlock_service.cc File chrome/browser/signin/easy_unlock_service.cc (right): https://codereview.chromium.org/799623003/diff/20001/chrome/browser/signin/easy_unlock_service.cc#newcode151 chrome/browser/signin/easy_unlock_service.cc:151: // Called when the remote device has been authenticated ...
6 years ago (2014-12-12 02:12:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799623003/60001
6 years ago (2014-12-12 20:02:44 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years ago (2014-12-12 22:19:31 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-12 22:20:26 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/06b9bfc16818e27a982e108053a880aea45a9f54
Cr-Commit-Position: refs/heads/master@{#308180}

Powered by Google App Engine
This is Rietveld 408576698