Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 799603002: Enforce thread-safety of bitmaps in pictures via the type. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Enforce thread-safety of bitmaps in pictures via the type. No runtime difference here, but it makes it impossible to forget to make a shallow copy; you can't get at the full bitmap without it. NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f55c314bfa6db980941f8d0ab485beb2e08589ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M src/core/SkRecordDraw.cpp View 3 chunks +5 lines, -10 lines 0 comments Download
M src/core/SkRecords.h View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein
6 years ago (2014-12-11 20:05:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799603002/1
6 years ago (2014-12-11 20:05:51 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-11 20:05:52 UTC) #5
reed1
lgtm
6 years ago (2014-12-11 20:33:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799603002/1
6 years ago (2014-12-11 20:42:53 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-11 20:43:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f55c314bfa6db980941f8d0ab485beb2e08589ab

Powered by Google App Engine
This is Rietveld 408576698