Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 799593004: Don't crash while detaching a pending child frame under --site-per-process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo inline of DiscardUnusedFrame Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 // Holds |render_frame_host| until it can be deleted when its swap out ACK 500 // Holds |render_frame_host| until it can be deleted when its swap out ACK
501 // arrives. 501 // arrives.
502 void MoveToPendingDeleteHosts( 502 void MoveToPendingDeleteHosts(
503 scoped_ptr<RenderFrameHostImpl> render_frame_host); 503 scoped_ptr<RenderFrameHostImpl> render_frame_host);
504 504
505 // Shutdown all RenderFrameProxyHosts in a SiteInstance. This is called to 505 // Shutdown all RenderFrameProxyHosts in a SiteInstance. This is called to
506 // shutdown frames when all the frames in a SiteInstance are confirmed to be 506 // shutdown frames when all the frames in a SiteInstance are confirmed to be
507 // swapped out. 507 // swapped out.
508 void ShutdownRenderFrameProxyHostsInSiteInstance(int32 site_instance_id); 508 void ShutdownRenderFrameProxyHostsInSiteInstance(int32 site_instance_id);
509 509
510 // Helper method to terminate the pending RenderViewHost. 510 // Helper method to terminate the pending RenderFrameHost. The frame may be
511 // deleted immediately, or it may be kept around in hopes of later reuse.
511 void CancelPending(); 512 void CancelPending();
512 513
514 // Clears pending_render_frame_host_, returning it to the caller for disposal.
515 scoped_ptr<RenderFrameHostImpl> UnsetPendingRenderFrameHost();
516
513 // Helper method to set the active RenderFrameHost. Returns the old 517 // Helper method to set the active RenderFrameHost. Returns the old
514 // RenderFrameHost and updates counts. 518 // RenderFrameHost and updates counts.
515 scoped_ptr<RenderFrameHostImpl> SetRenderFrameHost( 519 scoped_ptr<RenderFrameHostImpl> SetRenderFrameHost(
516 scoped_ptr<RenderFrameHostImpl> render_frame_host); 520 scoped_ptr<RenderFrameHostImpl> render_frame_host);
517 521
518 RenderFrameHostImpl* UpdateStateForNavigate( 522 RenderFrameHostImpl* UpdateStateForNavigate(
519 const GURL& url, 523 const GURL& url,
520 SiteInstance* instance, 524 SiteInstance* instance,
521 ui::PageTransition transition, 525 ui::PageTransition transition,
522 bool is_restore, 526 bool is_restore,
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 NotificationRegistrar registrar_; 606 NotificationRegistrar registrar_;
603 607
604 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 608 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
605 609
606 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 610 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
607 }; 611 };
608 612
609 } // namespace content 613 } // namespace content
610 614
611 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 615 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698