Fix float and half float support on mobile.

Fix float and half float support on mobile.

It's unclear what params should be used for half float alpha
rendertargets, so they are disabled for the moment.

Committed: https://skia.googlesource.com/skia/+/a60b2ead80c5442f35fb9109380ead98865e61be

[jvanverth1, 2014-12-11 20:08:06]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com

[jvanverth1, 2014-12-11 20:08:07]

Take two...

[bsalomon, 2014-12-11 20:17:04]

lgtm

https://codereview.chromium.org/799593002/diff/1/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/799593002/diff/1/src/gpu/gl/GrGLCaps.cpp#newc...
src/gpu/gl/GrGLCaps.cpp:643:
(ctxInfo.hasExtension("GL_OES_texture_half_float_linear") &&
just curious, in ES 3.1 is the GL_HALF_FLOAT value defined to be the same as the
desktop GL value or the GL_HALF_FLOAT value? Wondering if we need to
conditionally pass the OES only for es < 3.1

[jvanverth1, 2014-12-11 20:22:48]

On 2014/12/11 20:17:04, bsalomon wrote:
> lgtm
> 
> https://codereview.chromium.org/799593002/diff/1/src/gpu/gl/GrGLCaps.cpp
> File src/gpu/gl/GrGLCaps.cpp (right):
> 
>
https://codereview.chromium.org/799593002/diff/1/src/gpu/gl/GrGLCaps.cpp#newc...
> src/gpu/gl/GrGLCaps.cpp:643:
> (ctxInfo.hasExtension("GL_OES_texture_half_float_linear") &&
> just curious, in ES 3.1 is the GL_HALF_FLOAT value defined to be the same as
the
> desktop GL value or the GL_HALF_FLOAT value? Wondering if we need to
> conditionally pass the OES only for es < 3.1

The 3.1 spec says HALF_FLOAT, so I'd guess it's the non-OES one (there's no
hexcode specified). What's the best way to test that?

[bsalomon, 2014-12-11 20:30:38]

On 2014/12/11 20:22:48, jvanverth1 wrote:
> On 2014/12/11 20:17:04, bsalomon wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/799593002/diff/1/src/gpu/gl/GrGLCaps.cpp
> > File src/gpu/gl/GrGLCaps.cpp (right):
> > 
> >
>
https://codereview.chromium.org/799593002/diff/1/src/gpu/gl/GrGLCaps.cpp#newc...
> > src/gpu/gl/GrGLCaps.cpp:643:
> > (ctxInfo.hasExtension("GL_OES_texture_half_float_linear") &&
> > just curious, in ES 3.1 is the GL_HALF_FLOAT value defined to be the same as
> the
> > desktop GL value or the GL_HALF_FLOAT value? Wondering if we need to
> > conditionally pass the OES only for es < 3.1
> 
> The 3.1 spec says HALF_FLOAT, so I'd guess it's the non-OES one (there's no
> hexcode specified). What's the best way to test that?


The N9 is the only device I know of that we have that supports ES 3.1. But it
also supports the extension.

Here is the official ES3.1 header:
https://www.khronos.org/registry/gles/api/GLES3/gl31.h

It sez:
#define GL_HALF_FLOAT                     0x140B

[jvanverth1, 2014-12-11 20:39:29]

On 2014/12/11 20:30:38, bsalomon wrote:
> On 2014/12/11 20:22:48, jvanverth1 wrote:
> > On 2014/12/11 20:17:04, bsalomon wrote:
> > > lgtm
> > > 
> > > https://codereview.chromium.org/799593002/diff/1/src/gpu/gl/GrGLCaps.cpp
> > > File src/gpu/gl/GrGLCaps.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/799593002/diff/1/src/gpu/gl/GrGLCaps.cpp#newc...
> > > src/gpu/gl/GrGLCaps.cpp:643:
> > > (ctxInfo.hasExtension("GL_OES_texture_half_float_linear") &&
> > > just curious, in ES 3.1 is the GL_HALF_FLOAT value defined to be the same
as
> > the
> > > desktop GL value or the GL_HALF_FLOAT value? Wondering if we need to
> > > conditionally pass the OES only for es < 3.1
> > 
> > The 3.1 spec says HALF_FLOAT, so I'd guess it's the non-OES one (there's no
> > hexcode specified). What's the best way to test that?
> 
> 
> The N9 is the only device I know of that we have that supports ES 3.1. But it
> also supports the extension.
> 
> Here is the official ES3.1 header:
> https://www.khronos.org/registry/gles/api/GLES3/gl31.h
> 
> It sez:
> #define GL_HALF_FLOAT                     0x140B

From that and the spec it appears to be the same as desktop GL. Updated the
change to reflect that.

[jvanverth1, 2014-12-11 20:46:55]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-12-11 20:47:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/799593002/20001

[commit-bot: I haz the power, 2014-12-11 20:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-11 20:49:34]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[jvanverth1, 2014-12-12 13:49:32]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-12-12 13:49:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/799593002/40001

[commit-bot: I haz the power, 2014-12-12 13:58:10]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a60b2ead80c5442f35fb9109380ead98865e61be