Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Issue 799583002: Revert "mac: Allow Chrome to hand off its active URL to other devices." (Closed)

Created:
6 years ago by erikchen
Modified:
6 years ago
Reviewers:
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "mac: Allow Chrome to hand off its active URL to other devices." This breaks Mac Memory tests. They're still building 32-bit, and this CL used instance variables in a class extension, which is only supported in 64-bit builds. > This CL adds the class HandoffManager, which is responsible for interfacing > with Apple's Handoff APIs. It takes a GURL, and exposes that GURL to Handoff. > > This CL adds the class ActiveWebContentsObserver, which is responsible for > listening to changes to the active browser, the active tab, and the visible > URL. It notifies its delegate when any of this state might have changed. > > AppControllerMac is the delegate of ActiveWebContentsObserver, as well as the > owner of the HandoffManager. When it receives a delegate callback, it passes an > updated GURL to the HandoffManager. There is some minimal logic in > AppControllerMac that prevents URLs from incognito windows from being passed to > the HandoffManager. > > BUG=431051, 438823 > Committed: https://crrev.com/708abc5b0abb5e0916d779bf6d1342fd472a2aa1 > Cr-Commit-Position: refs/heads/master@{#307846} TBR=avi@chromium.org NOTRY=true BUG=431051, 438823 Committed: https://crrev.com/c429dd655de4317b2366440dd2c00ee4733136cf Cr-Commit-Position: refs/heads/master@{#307947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -642 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/app_controller_mac.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 7 chunks +2 lines, -121 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 2 chunks +0 lines, -143 lines 0 comments Download
D chrome/browser/ui/cocoa/handoff_active_url_observer.h View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/ui/cocoa/handoff_active_url_observer.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/ui/cocoa/handoff_active_url_observer_delegate.h View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M components/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/handoff.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
D components/handoff/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/handoff/handoff_manager.h View 1 chunk +0 lines, -22 lines 0 comments Download
D components/handoff/handoff_manager.mm View 1 chunk +0 lines, -97 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799583002/1
6 years ago (2014-12-11 19:28:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 19:30:20 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-11 19:31:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c429dd655de4317b2366440dd2c00ee4733136cf
Cr-Commit-Position: refs/heads/master@{#307947}

Powered by Google App Engine
This is Rietveld 408576698