Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 799543002: Let ShadowRoot.getElementById() fall back to DocumentFragment (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
hayato, dglazkov
CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Let ShadowRoot.getElementById() fall back to DocumentFragment ShadowRoot.getElementById() was added in 2012: http://trac.webkit.org/changeset/106434 DocumentFragment.getElementById() was added in 2014: https://codereview.chromium.org/251633002 The ShadowRoot override no longer serves any purpose. The argument becomes non-optional with this change, which is Web-observable. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187009

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LayoutTests/fast/dom/shadow/getelementbyid-shadow.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
update tests
6 years ago (2014-12-11 20:02:32 UTC) #1
philipj_slow
Dimitri, you get to review this since you reviewed its addition in 2012 :)
6 years ago (2014-12-11 20:04:03 UTC) #3
philipj_slow
Hayato, can you PTAL?
6 years ago (2014-12-12 08:54:21 UTC) #5
hayato
LGTM It seemed I forgot to remove getElementById from ShadowRoot when I removed it from ...
6 years ago (2014-12-12 08:57:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799543002/20001
6 years ago (2014-12-12 09:10:15 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 10:07:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187009

Powered by Google App Engine
This is Rietveld 408576698