Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 799533004: Move SkFontMgr and SkFontStyle impls to own cpp. (Closed)

Created:
5 years, 11 months ago by bungeman-skia
Modified:
5 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkFontMgr and SkFontStyle impls to own cpp. SkFontMgr and SkFontStyle implementations are currently burried in the old SkFontHost.cpp file. Move these implementations to their own file so that the implementations are easier to find, and to make clearer that SkFontHost.cpp needs to be removed. Committed: https://skia.googlesource.com/skia/+/e1a828c555223e75ebf83d0674daa2e6fd5889a3

Patch Set 1 #

Patch Set 2 : The header is elsewhere... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -245 lines) Patch
M gyp/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkFontHost.cpp View 2 chunks +0 lines, -174 lines 0 comments Download
A + src/core/SkFontMgr.cpp View 1 chunk +6 lines, -71 lines 0 comments Download
A src/core/SkFontStyle.cpp View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
Basic cleanup for sanity. I'm not sure how much work it is to get Chromium ...
5 years, 11 months ago (2015-01-20 18:28:06 UTC) #2
mtklein
lgtm
5 years, 11 months ago (2015-01-20 18:31:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799533004/1
5 years, 11 months ago (2015-01-20 18:39:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1971)
5 years, 11 months ago (2015-01-20 18:48:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799533004/20001
5 years, 11 months ago (2015-01-20 19:08:01 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 19:15:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e1a828c555223e75ebf83d0674daa2e6fd5889a3

Powered by Google App Engine
This is Rietveld 408576698