Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: Source/modules/accessibility/AXObject.cpp

Issue 799533003: Update some logic to check mixed state of ARIA elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed expectation diff. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/accessibility/aria-checkbox-checked-mixed-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXObject.cpp
diff --git a/Source/modules/accessibility/AXObject.cpp b/Source/modules/accessibility/AXObject.cpp
index 27670088bcd2ffee9e9648b330f436ff832a6a89..d4d99c2affaec06beb3b5ba635a6332c91b0ebb0 100644
--- a/Source/modules/accessibility/AXObject.cpp
+++ b/Source/modules/accessibility/AXObject.cpp
@@ -377,8 +377,12 @@ AccessibilityButtonState AXObject::checkboxOrRadioValue() const
const AtomicString& result = getAttribute(aria_checkedAttr);
if (equalIgnoringCase(result, "true"))
return ButtonStateOn;
- if (equalIgnoringCase(result, "mixed"))
+ if (equalIgnoringCase(result, "mixed")) {
+ AccessibilityRole role = ariaRoleAttribute();
+ if (role == RadioButtonRole || role == MenuItemRadioRole)
+ return ButtonStateOff;
return ButtonStateMixed;
+ }
return ButtonStateOff;
}
« no previous file with comments | « LayoutTests/accessibility/aria-checkbox-checked-mixed-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698