Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 799533003: Update some logic to check mixed state of ARIA elements. (Closed)

Created:
6 years ago by k.czech
Modified:
6 years ago
Reviewers:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update some logic to check mixed state of ARIA elements. Mixed state for radio buttons and menu item radio roles should be false regarding w3c spec. I'm also adding layout test to check it. BUG=170576, 418013 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187608

Patch Set 1 #

Patch Set 2 : Fixed expectation diff. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
A LayoutTests/accessibility/aria-checkbox-checked-mixed.html View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/aria-checkbox-checked-mixed-expected.txt View 1 1 chunk +17 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
k.czech
6 years ago (2014-12-19 14:17:55 UTC) #2
k.czech
On 2014/12/19 14:17:55, k.czech wrote: It's a second attempt to add this fix. Previously win8 ...
6 years ago (2014-12-19 14:29:32 UTC) #3
dmazzoni
lgtm
6 years ago (2014-12-22 07:57:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799533003/20001
6 years ago (2014-12-22 07:57:26 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-22 09:14:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187608

Powered by Google App Engine
This is Rietveld 408576698