Improve fidelity of XHR progress events.

Source/core/xml/XMLHttpRequestUpload.cpp

Index: Source/core/xml/XMLHttpRequestUpload.cpp
diff --git a/Source/core/xml/XMLHttpRequestUpload.cpp b/Source/core/xml/XMLHttpRequestUpload.cpp
index c6bfde05d9f20536e017908ae72127d8e2bff0c7..af0814bb6301b3feab6ae8451d2401d379f1b5e5 100644
--- a/Source/core/xml/XMLHttpRequestUpload.cpp
+++ b/Source/core/xml/XMLHttpRequestUpload.cpp
@@ -60,18 +60,18 @@ void XMLHttpRequestUpload::dispatchProgressEvent(unsigned long long bytesSent, u
     dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::progress, true, bytesSent, totalBytesToBeSent));
 }
 
-void XMLHttpRequestUpload::dispatchEventAndLoadEnd(PassRefPtr<Event> event)
+void XMLHttpRequestUpload::dispatchEventAndLoadEnd(const AtomicString& type, bool lengthComputable, unsigned long long bytesSent, unsigned long long total)
 {
-    ASSERT(event->type() == EventTypeNames::load || event->type() == EventTypeNames::abort || event->type() == EventTypeNames::error || event->type() == EventTypeNames::timeout);
-
-    dispatchEvent(event);
-    dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::loadend));
+    ASSERT(type == EventTypeNames::load || type == EventTypeNames::abort || type == EventTypeNames::error || type == EventTypeNames::timeout);
+    dispatchEvent(XMLHttpRequestProgressEvent::create(type, lengthComputable, bytesSent, total));
+    dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::loadend, lengthComputable, bytesSent, total));
 }
 
 void XMLHttpRequestUpload::handleRequestError(const AtomicString& type)
 {
-    dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::progress, true, m_lastBytesSent, m_lastTotalBytesToBeSent));
-    dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent::create(type));
+    bool lengthComputable = m_lastTotalBytesToBeSent > 0 && m_lastBytesSent <= m_lastTotalBytesToBeSent;

[tyoshino (SeeGerritForStatus), 2013/11/25 12:35:33]

yeah. it's fine to determine lengthComputable from the member variables. but we
cannot distinguish 0 set by dispatchProgressEvent() and initial 0.

[sof, 2013/11/25 13:30:38]

Does that matter, practically? if we haven't gotten any information from the
upload by the time we run into an error, then lengthComputable ought to be
false. And if we have delivered one or more upload progress events where no size
could be determined, if that can happen, then lengthComputable ought to be
false. So, we're ok?

[tyoshino (SeeGerritForStatus), 2013/11/25 13:39:14]

Ah,... right. And, if dispatchEventAndLoadEnd is called with
lengthComputable=true, total=0, it's done and handleRequestError won't be
invoked after that. So, we don't need to be worried about a case where we want
to dispatch an event with lengthComputable=true but total=0. That never happens.

Sorry. Never mind this comment.

+    dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::progress, lengthComputable, m_lastBytesSent, m_lastTotalBytesToBeSent));
+    dispatchEventAndLoadEnd(type, true, m_lastBytesSent, m_lastTotalBytesToBeSent);

[tyoshino (SeeGerritForStatus), 2013/11/25 12:35:33]

true -> lengthComputable?

[sof, 2013/11/25 15:28:18]

Done.

 }
 
 } // namespace WebCore