LayoutTests/http/tests/xmlhttprequest/ontimeout-event.html - Issue 79953004: Improve fidelity of XHR progress events.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/xmlhttprequest/ontimeout-event.html

Issue 79953004: Improve fidelity of XHR progress events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Avoid now-unnecessary argument defaulting Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/xmlhttprequest/onloadend-event-after-load.html ('K') | « LayoutTests/http/tests/xmlhttprequest/onloadend-event-after-load-expected.txt ('k') | LayoutTests/http/tests/xmlhttprequest/ontimeout-event-expected.txt » ('j') | LayoutTests/http/tests/xmlhttprequest/resources/post-echo.php » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 </head>

	7 <body>

	8 <p> Verify that a timeout ProgressEvent is dispatched and have the expected valu es.</p>

	9 <div id="log"></div>

	10 <script type="text/javascript">

	11

	12 function verifyProgressEvent(context, e)

	13 {

	14 assert_true(e.loaded > 0, "Non-zero 'loaded' value for '" + context + " ' ev ent.");
	tyoshino (SeeGerritForStatus) 2013/11/25 12:35:33 " ' event."); -> "' event."); " ' event."); -> "' event."); tyoshino (SeeGerritForStatus) 2013/11/25 12:35:33 e.loaded == 0 is rare and hard to observe but poss e.loaded == 0 is rare and hard to observe but possible, I think. just check if it's >= 0? sof 2013/11/25 15:28:18 Done. Show quoted text On 2013/11/25 12:35:33, tyoshino wrote: > " ' event."); > > -> > > "' event."); Done. sof 2013/11/25 15:28:18 Let's do that. Show quoted text On 2013/11/25 12:35:33, tyoshino wrote: > e.loaded == 0 is rare and hard to observe but possible, I think. > > just check if it's >= 0? Let's do that.
	15 assert_true(!e.lengthComputable \|\| e.total > 0, "Non-zero 'total' value for '" + context + "' event.");

	16 }

	17

	18 function logProgressEvent(e) {

	19 results += " " + e.type;

	20 }

	21

	22 function unexpectedProgressEvent(e) {

	23 assert_unreached("Unexpected request error");

	24 }

	25

	26 function timeoutHandler(e)

	27 {

	28 assert_true(e instanceof ProgressEvent);

	29 verifyProgressEvent("ontimeout", e);

	30 testOnTimeoutEvent.done();

	31 }

	32

	33 var testOnTimeoutEvent = async_test("Check that 'timeout' events are delivered a nd have expected values.");

	34 testOnTimeoutEvent.step(function () {

	35 var xhr = new XMLHttpRequest();

	36 xhr.ontimeout = testOnTimeoutEvent.step_func(timeoutHandler);

	37 xhr.onabort = testOnTimeoutEvent.step_func(unexpectedProgressEvent);

	38 xhr.onerror = testOnTimeoutEvent.step_func(unexpectedProgressEvent);

	39 xhr.onload = testOnTimeoutEvent.step_func(unexpectedProgressEvent);

	40 xhr.timeout = 30;

	41 xhr.open("GET", "resources/big-response.php", true);
	tyoshino (SeeGerritForStatus) 2013/11/25 12:35:33 how about using load-and-stall.php? maybe it'll le how about using load-and-stall.php? maybe it'll less flaky. sof 2013/11/25 15:28:18 Ah, didn't know of its existence. Switched. Show quoted text On 2013/11/25 12:35:33, tyoshino wrote: > how about using load-and-stall.php? maybe it'll less flaky. Ah, didn't know of its existence. Switched.
	42 xhr.send();

	43 });

	44 </script>

	45 </body>

	46 </html>

OLD	NEW