Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 799523003: Oilpan: insist on HTMLImportStateResolver stack allocation. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: insist on HTMLImportStateResolver stack allocation. Have the stack allocated HTMLImportStateResolver keep track of its HTMLImport reference by way of a Member. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Source/core/html/imports/HTMLImportStateResolver.h View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
Please take a look.
6 years ago (2014-12-13 13:27:31 UTC) #2
haraken
LGTM
6 years ago (2014-12-13 13:32:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799523003/1
6 years ago (2014-12-13 13:47:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41528)
6 years ago (2014-12-13 15:38:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799523003/1
6 years ago (2014-12-13 17:09:08 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-13 17:44:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187098

Powered by Google App Engine
This is Rietveld 408576698