Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 799523002: Split NonDocumentTypeChildNode from ChildNode (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Split NonDocumentTypeChildNode from ChildNode Blink is the only engine to still expose previousElementSibling and nextElementSibling and http://mail1.griffithscorp.com/ doesn't show a login button as a result. More importantly, this brings is in alignment with the spec and other browsers. BUG=441238 TEST=LayoutTests/fast/dom/DocumentType/previous-element-sibling.html LayoutTests/fast/dom/DocumentType/next-element-sibling.html LayoutTests/fast/dom/Element/element-traversal LayoutTests/fast/dom/Text/previous-element-sibling.html LayoutTests/fast/dom/Text/next-element-sibling.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -42 lines) Patch
M LayoutTests/fast/dom/DocumentType/next-element-sibling.html View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/DocumentType/next-element-sibling-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/DocumentType/previous-element-sibling.html View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/DocumentType/previous-element-sibling-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Text/next-element-sibling.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Text/next-element-sibling-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Text/previous-element-sibling.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Text/previous-element-sibling-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/CharacterData.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ChildNode.h View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/dom/ChildNode.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/core/dom/NonDocumentTypeChildNode.h View 2 chunks +4 lines, -9 lines 0 comments Download
A Source/core/dom/NonDocumentTypeChildNode.idl View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years ago (2014-12-11 13:42:45 UTC) #2
arv (Not doing code reviews)
LGTM
6 years ago (2014-12-11 16:42:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799523002/1
6 years ago (2014-12-11 17:00:34 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 18:08:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186969

Powered by Google App Engine
This is Rietveld 408576698