Source/core/rendering/RenderLayer.cpp - Issue 79943002: Only not take zOffset into account during hit-testing when child layers are in the same 3d renderin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 79943002: Only not take zOffset into account during hit-testing when child layers are in the same 3d renderin… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Sorry for the late delay. Here is an updated patch. I've put the description under the tested eleme… Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/transforms/3d/hit-testing/overlapping-layers-hit-test.html ('K') | « LayoutTests/transforms/3d/hit-testing/overlapping-layers-hit-test-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayer.cpp

diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp

index 9e24170a350a2479773e8459571027253a111896..1f0d38c707d86f164b5ce6cd1923cf70d45bfb1b 100644

--- a/Source/core/rendering/RenderLayer.cpp

+++ b/Source/core/rendering/RenderLayer.cpp

@@ -2858,11 +2858,6 @@ RenderLayer* RenderLayer::hitTestLayer(RenderLayer* rootLayer, RenderLayer* cont

// Our layers can depth-test with our container, so share the z depth pointer with the container, if it passed one down.

zOffsetForDescendantsPtr = zOffset ? zOffset : &localZOffset;

zOffsetForContentsPtr = zOffset ? zOffset : &localZOffset;

- } else if (m_has3DTransformedDescendant) {

- // Flattening layer with 3d children; use a local zOffset pointer to depth-test children and foreground.

- depthSortDescendants = true;

- zOffsetForDescendantsPtr = zOffset ? zOffset : &localZOffset;

- zOffsetForContentsPtr = zOffset ? zOffset : &localZOffset;

} else if (zOffset) {

zOffsetForDescendantsPtr = 0;

// Container needs us to give back a z offset for the hit layer.