Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 79943002: Only not take zOffset into account during hit-testing when child layers are in the same 3d renderin… (Closed)

Created:
7 years, 1 month ago by a.renevier
Modified:
6 years, 5 months ago
CC:
bemjb+rendering_chromium.org, blink-layers+watch_chromium.org, blink-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Only not take zOffset into account during hit-testing when child layers are in the same 3d rendering context Currently, hit-testing computes zOffset of layers with transformations. When two layers overlap, it returns the layer with the highest zOffset. Hit-testing should behave this way only when preserve3d is true. BUG=126479, 310464 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177685

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 7

Patch Set 3 : Sorry for the late delay. Here is an updated patch. I've put the description under the tested eleme… #

Total comments: 5

Patch Set 4 : #

Messages

Total messages: 12 (0 generated)
a.renevier
7 years, 1 month ago (2013-11-21 00:23:50 UTC) #1
shawnsingh
On 2013/11/21 00:23:50, a.renevier wrote: Nice! Thank you so much. I will make time to ...
7 years, 1 month ago (2013-11-21 00:58:13 UTC) #2
shawnsingh
Nice patch... This does look correct to me. non-owner LGTM with one comment below. +jchaffraix ...
7 years, 1 month ago (2013-11-21 09:17:32 UTC) #3
Mihai Maerean
Can you please add to this patch the hover-rotated-with-children-negative-z.html layout test from this patch (https://codereview.chromium.org/81153002/) ...
7 years, 1 month ago (2013-11-22 16:26:57 UTC) #4
a.renevier
On 2013/11/22 16:26:57, Mihai Maerean wrote: > Can you please add to this patch the ...
7 years, 1 month ago (2013-11-23 00:00:44 UTC) #5
Julien - ping for review
The code change is fine, the tests need a bit more work. https://codereview.chromium.org/79943002/diff/100001/LayoutTests/transforms/3d/hit-testing/hover-rotated-with-children-negative-z.html File LayoutTests/transforms/3d/hit-testing/hover-rotated-with-children-negative-z.html ...
7 years ago (2013-11-25 03:40:17 UTC) #6
a.renevier
Sorry for the late delay. Here is an updated patch. I've put the description under ...
6 years, 11 months ago (2014-01-09 20:42:26 UTC) #7
Julien - ping for review
lgtm https://codereview.chromium.org/79943002/diff/180001/LayoutTests/transforms/3d/hit-testing/negative-zoffset-hit-test.html File LayoutTests/transforms/3d/hit-testing/negative-zoffset-hit-test.html (right): https://codereview.chromium.org/79943002/diff/180001/LayoutTests/transforms/3d/hit-testing/negative-zoffset-hit-test.html#newcode4 LayoutTests/transforms/3d/hit-testing/negative-zoffset-hit-test.html:4: <style type="text/css"> The type="text/css" is unneeded so it's ...
6 years, 11 months ago (2014-01-10 13:59:53 UTC) #8
a.renevier
Same patch with nits corrected. Should I commit it now?
6 years, 5 months ago (2014-07-02 23:24:20 UTC) #9
Julien - ping for review
We should! lgtm
6 years, 5 months ago (2014-07-08 15:22:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.renevier@samsung.com/79943002/250001
6 years, 5 months ago (2014-07-08 15:22:59 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 19:51:44 UTC) #12
Message was sent while issue was closed. 
Change committed as 177685

Powered by Google App Engine
This is Rietveld 408576698