Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 799413002: [turbofan] Relax effects and context for JSToNumber(x:plain-primitive). (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Relax effects and context for JSToNumber(x:plain-primitive). Relanded with fix for always returning Change for PlainPrimitive even if there was no change. The performance regression on primes.js and corrections.js is due to unlucky loop header alignment; will be addressed separately. TEST=unittests R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/75484e8d16866eba7aa9c3b87841cd6ce2f466b8 Committed: https://crrev.com/283175d984cc3b7796d537a2b821b28e9c316c16 Cr-Commit-Position: refs/heads/master@{#25832}

Patch Set 1 #

Patch Set 2 : Don't always return Changed for plain-primitive inputs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 6 chunks +13 lines, -5 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Benedikt Meurer
6 years ago (2014-12-15 13:12:57 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-15 13:13:19 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-15 13:42:09 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 75484e8d16866eba7aa9c3b87841cd6ce2f466b8 (presubmit successful).
6 years ago (2014-12-15 13:43:02 UTC) #4
Benedikt Meurer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/806103002/ by bmeurer@chromium.org. ...
6 years ago (2014-12-16 04:44:41 UTC) #5
Benedikt Meurer
Committed patchset #2 (id:20001) manually as 283175d984cc3b7796d537a2b821b28e9c316c16 (presubmit successful).
6 years ago (2014-12-16 05:39:54 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/75484e8d16866eba7aa9c3b87841cd6ce2f466b8 Cr-Commit-Position: refs/heads/master@{#25818}
6 years ago (2014-12-17 10:13:21 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 10:13:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/283175d984cc3b7796d537a2b821b28e9c316c16
Cr-Commit-Position: refs/heads/master@{#25832}

Powered by Google App Engine
This is Rietveld 408576698