Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 799403008: replace COMPILE_ASSERT with static_assert in core/editing/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
Nico, Yuta Kitamura
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in core/editing/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/editing/HTMLInterchange.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mostyn Bramley-Moore
@yutak: PTAL.
6 years ago (2014-12-16 22:43:49 UTC) #2
Mostyn Bramley-Moore
On 2014/12/16 22:43:49, Mostyn Bramley-Moore wrote: > @yutak: PTAL. *ping* @Nico: perhaps you can rubber-stamp ...
6 years ago (2014-12-19 12:25:09 UTC) #4
Nico
sure, lgtm if I'm owner here
6 years ago (2014-12-19 19:04:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799403008/1
6 years ago (2014-12-19 19:05:06 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-19 20:31:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187560

Powered by Google App Engine
This is Rietveld 408576698