Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 799403007: Add counters for all of the WebAudio nodes and important methods. (Closed)

Created:
6 years ago by Raymond Toy
Modified:
5 years, 7 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add counters for all of the WebAudio nodes and important methods. Also add a deprecation message for the prefixed webkitAudioContext and webkitOfflineAudioContext. BUG=405346 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187398

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix typos #

Total comments: 5

Patch Set 4 : Rebase and update according to review #

Patch Set 5 : Fix test to use OfflineAudioContext, not prefixed version #

Patch Set 6 : Update expected results due to prefixed webkit warnings #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase take 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -26 lines) Patch
M LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/global-constructors-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/webaudio/mediaelementaudiosourcenode-wrapper.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 5 6 7 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioContext.idl View 1 2 1 chunk +21 lines, -21 lines 0 comments Download
M Source/modules/webaudio/WindowWebAudio.idl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (10 generated)
Raymond Toy
PTAL.
6 years ago (2014-12-17 00:26:46 UTC) #2
Ken Russell (switch to Gerrit)
LGTM Please make sure to announce this deprecation publicly. https://codereview.chromium.org/799403007/diff/30001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/799403007/diff/30001/Source/core/frame/UseCounter.cpp#newcode837 Source/core/frame/UseCounter.cpp:837: ...
6 years ago (2014-12-17 00:44:30 UTC) #3
Raymond Toy
On 2014/12/17 00:44:30, Ken Russell wrote: > LGTM > > Please make sure to announce ...
6 years ago (2014-12-17 05:10:49 UTC) #4
Raymond Toy
https://codereview.chromium.org/799403007/diff/30001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/799403007/diff/30001/Source/core/frame/UseCounter.cpp#newcode837 Source/core/frame/UseCounter.cpp:837: return "webkitAudioContext is deprecated; use AudioContext instead"; On 2014/12/17 ...
6 years ago (2014-12-17 05:53:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799403007/50001
6 years ago (2014-12-17 05:53:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/39189)
6 years ago (2014-12-17 07:12:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799403007/70001
6 years ago (2014-12-17 07:29:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/39199) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42249)
6 years ago (2014-12-17 08:47:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799403007/90001
6 years ago (2014-12-17 16:00:40 UTC) #15
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years ago (2014-12-17 16:01:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799403007/110001
6 years ago (2014-12-17 16:12:59 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/38109)
6 years ago (2014-12-17 17:39:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799403007/130001
6 years ago (2014-12-17 18:12:34 UTC) #23
commit-bot: I haz the power
Committed patchset #8 (id:130001) as https://src.chromium.org/viewvc/blink?view=rev&revision=187398
6 years ago (2014-12-17 20:31:15 UTC) #24
philipj_slow
On 2014/12/17 00:44:30, Ken Russell wrote: > LGTM > > Please make sure to announce ...
6 years ago (2014-12-18 15:44:16 UTC) #25
philipj_slow
I noticed in https://codereview.chromium.org/1141733002 that AudioContextCreateStereoPanner was added but not used in this CL. Probably ...
5 years, 7 months ago (2015-05-13 13:00:53 UTC) #26
Raymond Toy
5 years, 7 months ago (2015-05-13 15:34:38 UTC) #27
Message was sent while issue was closed. 
On 2015/05/13 13:00:53, philipj_UTC2 wrote:
> I noticed in https://codereview.chromium.org/1141733002 that
> AudioContextCreateStereoPanner was added but not used in this CL. Probably not
> intentional?

Oops.  That's a typo. I'll fix it right away.

Powered by Google App Engine
This is Rietveld 408576698