Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 799393005: Merge all StyleSheetCollections. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Merge all StyleSheetCollections. We don't need all these subtypes, or to create the base class as to what amounts to a thin wrapper around a Vector. Instead lets merge all the types together. Future patches will remove the special cases inside the collection for Document vs ShadowRoot. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b32f998e845b1761cd05fc6dc62f9ec977e75141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -452 lines) Patch
M sky/engine/core/core.gni View 3 chunks +0 lines, -6 lines 0 comments Download
D sky/engine/core/dom/DocumentStyleSheetCollection.h View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/engine/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
D sky/engine/core/dom/ShadowTreeStyleSheetCollection.h View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/engine/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 6 chunks +8 lines, -11 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 9 chunks +9 lines, -13 lines 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.h View 1 chunk +23 lines, -8 lines 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.cpp View 2 chunks +62 lines, -7 lines 0 comments Download
D sky/engine/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/engine/core/dom/TreeScopeStyleSheetCollection.cpp View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eseidel
lgtm
6 years ago (2014-12-16 03:46:22 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-16 03:49:45 UTC) #5
esprehn
6 years ago (2014-12-16 20:41:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b32f998e845b1761cd05fc6dc62f9ec977e75141 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698