Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 799343002: Fix hitting assert when opening a select menu with no options (Closed)

Created:
6 years ago by keishi
Modified:
6 years ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Fix hitting assert when opening a select menu with no options TEST=Layout test be added in https://codereview.chromium.org/736883002/ BUG=346582 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187124

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +0 lines, -4 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
keishi
6 years ago (2014-12-15 08:32:14 UTC) #2
tkent
lgtm https://codereview.chromium.org/799343002/diff/1/Source/core/html/HTMLSelectElement.cpp File Source/core/html/HTMLSelectElement.cpp (left): https://codereview.chromium.org/799343002/diff/1/Source/core/html/HTMLSelectElement.cpp#oldcode1211 Source/core/html/HTMLSelectElement.cpp:1211: setSelectedIndex(index); Hmm, setSelectedIndex(selectedIndex()) looks to do nothing, and ...
6 years ago (2014-12-15 08:56:25 UTC) #3
keishi
https://codereview.chromium.org/799343002/diff/1/Source/core/html/HTMLSelectElement.cpp File Source/core/html/HTMLSelectElement.cpp (left): https://codereview.chromium.org/799343002/diff/1/Source/core/html/HTMLSelectElement.cpp#oldcode1211 Source/core/html/HTMLSelectElement.cpp:1211: setSelectedIndex(index); On 2014/12/15 08:56:25, unavailable until Feburuary wrote: > ...
6 years ago (2014-12-15 09:01:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799343002/1
6 years ago (2014-12-15 09:01:47 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 10:27:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187124

Powered by Google App Engine
This is Rietveld 408576698