Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: remoting/proto/event.proto

Issue 799233004: Add touch events to the protocol, the stub layer, and to the client plugin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed TouchInputFilter to TouchInputScaler and moved to client/plugin Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/proto/event.proto
diff --git a/remoting/proto/event.proto b/remoting/proto/event.proto
index dd150942b771df1fab75e72512bac3d28ded5a6b..00c40012cc87523f7d805fc4baf55dc54e41e7a3 100644
--- a/remoting/proto/event.proto
+++ b/remoting/proto/event.proto
@@ -79,3 +79,35 @@ message ClipboardEvent {
// The data being sent.
optional bytes data = 2;
}
+
+message TouchEventPoint {
+
+ // The ID for the touch point.
+ optional uint32 id = 1;
+
+ // The position of the touch point.
+ // These values on-the-wire are host coordinates.
+ optional float x = 2;
+ optional float y = 3;
+
+ // The size of the touch point, used to aid hit-testing.
+ // Unlike x,y coordinates, these will not be scaled.
Sergey Ulanov 2015/01/29 18:00:46 You also need rotation angle. It's not useful to s
Rintaro Kuroiwa 2015/01/30 17:57:02 Done.
+ optional float radius_x = 4;
Sergey Ulanov 2015/01/29 18:00:46 Do we also need a field for pressure/force?
Rintaro Kuroiwa 2015/01/30 17:57:02 wez mentioned that rotation angle and pressure are
Sergey Ulanov 2015/02/02 19:32:05 We do get pressure values on Android, Web and Pepp
Rintaro Kuroiwa 2015/02/02 22:22:56 Done.
+ optional float radius_y = 5;
+}
+
+message TouchEvent {
+
+ enum TouchEventType {
+ TOUCH_POINT_START = 1;
Sergey Ulanov 2015/01/29 18:00:46 I'm not sure I understand what these types mean. E
Rintaro Kuroiwa 2015/01/30 17:57:02 When a user starts touching a screen with a new fi
Sergey Ulanov 2015/02/02 19:32:05 I see. What's confusing to me is that there are mu
Rintaro Kuroiwa 2015/02/02 22:22:56 Repeating myself what we discussed offline. Corre
+ TOUCH_POINT_MOVE = 2;
+ TOUCH_POINT_END = 3;
+ // Cancel event is different from END. For example, Android MotionEvent's
+ // ACTION_CANCEL should be treated as UP (END) but might not perform the
+ // same action as UP.
+ TOUCH_POINT_CANCEL = 4;
+ };
+
+ optional TouchEventType event_type = 1;
+ repeated TouchEventPoint touch_points = 2;
Sergey Ulanov 2015/01/29 18:00:46 Should this include all current touches or only th
Rintaro Kuroiwa 2015/01/30 17:57:02 Only those points that changed. This seems to be t
+}

Powered by Google App Engine
This is Rietveld 408576698