Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: remoting/proto/event.proto

Issue 799233004: Add touch events to the protocol, the stub layer, and to the client plugin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mac builds Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/proto/event.proto
diff --git a/remoting/proto/event.proto b/remoting/proto/event.proto
index dd150942b771df1fab75e72512bac3d28ded5a6b..61c2701a46ef3e19138a6767b9f1e2a56089b8d4 100644
--- a/remoting/proto/event.proto
+++ b/remoting/proto/event.proto
@@ -79,3 +79,39 @@ message ClipboardEvent {
// The data being sent.
optional bytes data = 2;
}
+
+message TouchEvent {
+
+ message Point {
Wez 2015/01/21 03:08:37 If you define this as TouchPoint or TouchEventPoin
Rintaro Kuroiwa 2015/01/28 01:12:29 Done.
+ enum TouchPointEventType {
+ // The types map to event types in PP_InputEvent_Type.
+ TOUCH_POINT_START = 1;
+ TOUCH_POINT_MOVE = 2;
+ TOUCH_POINT_END = 3;
+ // Cancel event is different from END. For example on Android,
+ // CANCEL should be treated as up (END) but might not perform some
+ // actions.
Wez 2015/01/21 03:08:37 This is confusingly worded; I think what you mean
Rintaro Kuroiwa 2015/01/28 01:12:29 If I understood you correctly, you mean CANCEL can
+ TOUCH_POINT_CANCEL = 4;
+ };
+
+ optional TouchPointEventType event_type = 1;
Wez 2015/01/21 03:08:37 Doesn't this belong in the TouchEvent, rather than
Rintaro Kuroiwa 2015/01/28 01:12:29 Yes. Initially I thought I would need an event tha
+
+ // The ID for the point.
+ optional uint32 id = 2;
+
+ // The position of the point.
+ // If the client is scaling the view (shrink or zoom), these will be scaled
+ // as well.
Wez 2015/01/21 03:08:37 This comment is not relevant to the protocol; at t
Rintaro Kuroiwa 2015/01/28 01:12:29 Done.
+ // These values on-the-wire are host coordinates.
+ optional float x = 3;
+ optional float y = 4;
+
+ // x and y values that define the ellipse of the touch region.
+ // This determines the size of the touch region.
Wez 2015/01/21 03:08:37 Suggest combining these to something like: The si
Rintaro Kuroiwa 2015/01/28 01:12:29 Done.
+ // Unlike x,y coordinates, these will not be scaled.
Wez 2015/01/21 03:08:37 Why not?
Rintaro Kuroiwa 2015/01/28 01:12:29 I actually don't have a good reason for or against
Rintaro Kuroiwa 2015/01/29 07:37:46 After giving it some more thought, scaling the siz
+ optional float radius_x = 5;
+ optional float radius_y = 6;
+ }
+
+ repeated Point touch_points = 1;
+}

Powered by Google App Engine
This is Rietveld 408576698