tools/perf/page_sets/service_worker.py - Issue 799183002: Rename AddPage -> AddUserStory in tools/perf/page_sets/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/service_worker.py

Issue 799183002: Rename AddPage -> AddUserStory in tools/perf/page_sets/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/service_worker.py

diff --git a/tools/perf/page_sets/service_worker.py b/tools/perf/page_sets/service_worker.py

index aabb62a861a447a5ba7ba87b4b451598a3708f0a..2ac1c6bf9efe1c3ffc432247e631c9020f92f840 100644

--- a/tools/perf/page_sets/service_worker.py

+++ b/tools/perf/page_sets/service_worker.py

@@ -20,11 +20,11 @@ class ServiceWorkerPageSet(page_set.PageSet):

# Why: the first application using ServiceWorker

# 1st time: registration

- self.AddPage(page.Page(

+ self.AddUserStory(page.Page(

'https://jakearchibald.github.io/trained-to-thrill/', self))

# 2st time: 1st onfetch with caching

- self.AddPage(page.Page(

+ self.AddUserStory(page.Page(

'https://jakearchibald.github.io/trained-to-thrill/', self))

# 3rd time: 2nd onfetch from cache

- self.AddPage(page.Page(

+ self.AddUserStory(page.Page(

'https://jakearchibald.github.io/trained-to-thrill/', self))

« no previous file with comments | « tools/perf/page_sets/polymer.py ('k') | tools/perf/page_sets/service_worker_micro_benchmark.py » ('j') | no next file with comments »