tools/perf/page_sets/key_desktop_sites.py - Issue 799183002: Rename AddPage -> AddUserStory in tools/perf/page_sets/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_desktop_sites.py

Issue 799183002: Rename AddPage -> AddUserStory in tools/perf/page_sets/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/key_desktop_sites.py

diff --git a/tools/perf/page_sets/key_desktop_sites.py b/tools/perf/page_sets/key_desktop_sites.py

index 69dca11d5dacdab2f334e3caea8788705b1b7ef4..a51202761dccba01219b0283488c2765a2732452 100644

--- a/tools/perf/page_sets/key_desktop_sites.py

+++ b/tools/perf/page_sets/key_desktop_sites.py

@@ -122,11 +122,11 @@ class KeyDesktopSitesPageSet(page_set_module.PageSet):

archive_data_file='data/key_desktop_sites.json',

bucket=page_set_module.PARTNER_BUCKET)

- self.AddPage(FacebookPage(self))

- self.AddPage(GmailPage(self))

- self.AddPage(GoogleCalendarPage(self))

- self.AddPage(GoogleDrivePage(self))

- self.AddPage(GoogleDocPage(self))

+ self.AddUserStory(FacebookPage(self))

+ self.AddUserStory(GmailPage(self))

+ self.AddUserStory(GoogleCalendarPage(self))

+ self.AddUserStory(GoogleDrivePage(self))

+ self.AddUserStory(GoogleDocPage(self))

urls_list = [

'http://www.google.com/nexus/5/#/',

@@ -850,4 +850,4 @@ class KeyDesktopSitesPageSet(page_set_module.PageSet):

]

for url in urls_list:

- self.AddPage(KeyDesktopSitesPage(url, self))

+ self.AddUserStory(KeyDesktopSitesPage(url, self))

« no previous file with comments | « tools/perf/page_sets/intl_ko_th_vi.py ('k') | tools/perf/page_sets/key_hit_test_cases.py » ('j') | no next file with comments »