tools/perf/page_sets/startup_pages.py - Issue 799183002: Rename AddPage -> AddUserStory in tools/perf/page_sets/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/startup_pages.py

Issue 799183002: Rename AddPage -> AddUserStory in tools/perf/page_sets/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/perf/page_sets/simple_mobile_sites.py ('k') | tools/perf/page_sets/startup_pages_record.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from telemetry.page import page as page_module	4 from telemetry.page import page as page_module

5 from telemetry.page import page_set as page_set_module	5 from telemetry.page import page_set as page_set_module

6	6

7	7

8 class StartedPage(page_module.Page):	8 class StartedPage(page_module.Page):

9	9

10 def __init__(self, url, startup_url, page_set):	10 def __init__(self, url, startup_url, page_set):

(...skipping 11 matching lines...) Expand all Loading...
22 a true navigate step, which we do not want for startup testing. Instead use	22 a true navigate step, which we do not want for startup testing. Instead use

23 record_wpr startup_pages_record to record data for this test.	23 record_wpr startup_pages_record to record data for this test.

24 """	24 """

25	25

26 def __init__(self):	26 def __init__(self):

27 super(StartupPagesPageSet, self).__init__(	27 super(StartupPagesPageSet, self).__init__(

28 archive_data_file='data/startup_pages.json',	28 archive_data_file='data/startup_pages.json',

29 bucket=page_set_module.PARTNER_BUCKET)	29 bucket=page_set_module.PARTNER_BUCKET)

30	30

31 # Typical page.	31 # Typical page.

32 self.AddPage(StartedPage('about:blank', 'about:blank', self))	32 self.AddUserStory(StartedPage('about:blank', 'about:blank', self))

33 # Typical page.	33 # Typical page.

34 self.AddPage(StartedPage('http://bbc.co.uk', 'http://bbc.co.uk', self))	34 self.AddUserStory(StartedPage('http://bbc.co.uk', 'http://bbc.co.uk', self))

35 # Horribly complex page - stress test!	35 # Horribly complex page - stress test!

36 self.AddPage(StartedPage('http://kapook.com', 'http://kapook.com', self))	36 self.AddUserStory(StartedPage(

	37 'http://kapook.com', 'http://kapook.com', self))

OLD	NEW