Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 799143002: Remove single client special cases for StyleSheetContents. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove single client special cases for StyleSheetContents. We can also remove all single document checks since in Sky we don't have the cross document cache so all sheets are always connected to a single document. I also did some minor code simplification and removed an OILPAN ifdef. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/630674b241ebb0752f88868dc2163bfa9cea1eb1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -77 lines) Patch
M sky/engine/core/css/StyleSheetContents.h View 3 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 5 chunks +5 lines, -58 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/UseCounter.cpp View 1 chunk +1 line, -4 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
esprehn
6 years ago (2014-12-13 00:50:50 UTC) #2
ojan
lgtm https://codereview.chromium.org/799143002/diff/1/sky/engine/core/frame/UseCounter.cpp File sky/engine/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/799143002/diff/1/sky/engine/core/frame/UseCounter.cpp#newcode257 sky/engine/core/frame/UseCounter.cpp:257: // TODO(esprehn): Support this in Sky. Is this ...
6 years ago (2014-12-13 00:55:38 UTC) #3
esprehn
On 2014/12/13 at 00:55:38, ojan wrote: > lgtm > > https://codereview.chromium.org/799143002/diff/1/sky/engine/core/frame/UseCounter.cpp > File sky/engine/core/frame/UseCounter.cpp (right): ...
6 years ago (2014-12-13 01:06:08 UTC) #4
esprehn
On 2014/12/13 at 01:06:08, esprehn wrote: > On 2014/12/13 at 00:55:38, ojan wrote: > > ...
6 years ago (2014-12-13 01:07:46 UTC) #5
esprehn
6 years ago (2014-12-13 01:08:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
630674b241ebb0752f88868dc2163bfa9cea1eb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698