Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 799113003: Remove hasFailedOrCanceledSubresources. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove hasFailedOrCanceledSubresources. This was used to skip caching sheets across documents that had failed resource loads so that when you loaded a new tab with the same resource we'd attempt to load it again. The cross document cache (which was only used by <link>) doesn't exist in Sky, and neither does CSSStyleSheetResource which used it, so we can remove all this code. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/73c2a1183a79df0308c0f9c595c13d34da9ecd3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -122 lines) Patch
M sky/engine/core/css/CSSCrossfadeValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSCrossfadeValue.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/css/CSSFontFaceSrcValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/CSSImageSetValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSImageSetValue.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/css/CSSImageValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSImageValue.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/css/CSSValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSValue.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M sky/engine/core/css/CSSValueList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSValueList.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-12 23:02:33 UTC) #2
ojan
lgtm
6 years ago (2014-12-12 23:39:53 UTC) #3
esprehn
6 years ago (2014-12-12 23:41:58 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
73c2a1183a79df0308c0f9c595c13d34da9ecd3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698