Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: util/net/http_transport_test.cc

Issue 799083003: util_test: Don’t crash when run from the wrong location (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: util/net/http_transport_test.cc
diff --git a/util/net/http_transport_test.cc b/util/net/http_transport_test.cc
index 974e9f05411a1152b7c69e9593e94c2043220cd7..648501c15d701dcb9b676953f8f47fb58fdca768 100644
--- a/util/net/http_transport_test.cc
+++ b/util/net/http_transport_test.cc
@@ -58,9 +58,11 @@ class HTTPTransportTestFixture : public MultiprocessExec {
private:
void MultiprocessParent() override {
// The child will write the HTTP server port number as a packed unsigned
- // short to stdout.
+ // short to stdout. Use LoggingReadFD() instead of CheckedReadFD() for the
+ // first read so that the test can fail gracefully with a gtest assertion
+ // if the child does not execute properly.
uint16_t port;
- CheckedReadFD(ReadPipeFD(), &port, sizeof(port));
+ ASSERT_TRUE(LoggingReadFD(ReadPipeFD(), &port, sizeof(port)));
// Then the parent will tell the web server what response code to send
// for the HTTP request.

Powered by Google App Engine
This is Rietveld 408576698