Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: util/test/multiprocess_exec_test.cc

Issue 799083003: util_test: Don’t crash when run from the wrong location (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback, round 2 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/net/http_transport_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 15 matching lines...) Expand all
26 namespace { 26 namespace {
27 27
28 class TestMultiprocessExec final : public MultiprocessExec { 28 class TestMultiprocessExec final : public MultiprocessExec {
29 public: 29 public:
30 TestMultiprocessExec() : MultiprocessExec() {} 30 TestMultiprocessExec() : MultiprocessExec() {}
31 31
32 ~TestMultiprocessExec() {} 32 ~TestMultiprocessExec() {}
33 33
34 private: 34 private:
35 void MultiprocessParent() override { 35 void MultiprocessParent() override {
36 // Use Logging*FD() instead of Checked*FD() so that the test can fail
37 // gracefully with a gtest assertion if the child does not execute properly.
38
36 char c = 'z'; 39 char c = 'z';
37 CheckedWriteFD(WritePipeFD(), &c, 1); 40 ASSERT_TRUE(LoggingWriteFD(WritePipeFD(), &c, 1));
38 41
39 CheckedReadFD(ReadPipeFD(), &c, 1); 42 ASSERT_TRUE(LoggingReadFD(ReadPipeFD(), &c, 1));
40 EXPECT_EQ('Z', c); 43 EXPECT_EQ('Z', c);
41 } 44 }
42 45
43 DISALLOW_COPY_AND_ASSIGN(TestMultiprocessExec); 46 DISALLOW_COPY_AND_ASSIGN(TestMultiprocessExec);
44 }; 47 };
45 48
46 TEST(MultiprocessExec, MultiprocessExec) { 49 TEST(MultiprocessExec, MultiprocessExec) {
47 TestMultiprocessExec multiprocess_exec; 50 TestMultiprocessExec multiprocess_exec;
48 base::FilePath test_executable = ExecutablePath(); 51 base::FilePath test_executable = ExecutablePath();
49 std::string child_test_executable = 52 std::string child_test_executable =
50 test_executable.value() + "_multiprocess_exec_test_child"; 53 test_executable.value() + "_multiprocess_exec_test_child";
51 multiprocess_exec.SetChildCommand(child_test_executable, nullptr); 54 multiprocess_exec.SetChildCommand(child_test_executable, nullptr);
52 multiprocess_exec.Run(); 55 multiprocess_exec.Run();
53 } 56 }
54 57
55 } // namespace 58 } // namespace
56 } // namespace test 59 } // namespace test
57 } // namespace crashpad 60 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/net/http_transport_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698