Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 799083003: util_test: Don’t crash when run from the wrong location (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

util_test: Don’t crash when run from the wrong location. When run from the wrong location and test data or other test programs can’t be found, the tests should fail with gtest assertions. The test executable should not crash. BUG=crashpad:4 TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/22cf9e28d53bf7eaf834f2c2ba2d8ec2b9ecd1bc

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Total comments: 1

Patch Set 3 : Address review feedback, round 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M util/net/http_multipart_builder_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M util/net/http_transport_test.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M util/test/multiprocess_exec_test.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years ago (2014-12-12 22:05:49 UTC) #2
Robert Sesek
https://codereview.chromium.org/799083003/diff/1/util/test/multiprocess_exec_test.cc File util/test/multiprocess_exec_test.cc (right): https://codereview.chromium.org/799083003/diff/1/util/test/multiprocess_exec_test.cc#newcode37 util/test/multiprocess_exec_test.cc:37: CheckedWriteFD(WritePipeFD(), &c, 1); Change this to a LoggingX?
6 years ago (2014-12-15 19:41:18 UTC) #3
Mark Mentovai
Updated.
6 years ago (2014-12-15 19:47:06 UTC) #4
Robert Sesek
LGTM w/ one more https://codereview.chromium.org/799083003/diff/20001/util/net/http_transport_test.cc File util/net/http_transport_test.cc (right): https://codereview.chromium.org/799083003/diff/20001/util/net/http_transport_test.cc#newcode69 util/net/http_transport_test.cc:69: CheckedWriteFD(WritePipeFD(), &response_code_, sizeof(response_code_)); I guess ...
6 years ago (2014-12-15 21:09:21 UTC) #5
Mark Mentovai
6 years ago (2014-12-15 21:40:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
22cf9e28d53bf7eaf834f2c2ba2d8ec2b9ecd1bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698